Debugger improvements #325
Merged
+127
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #325 +/- ##
==========================================
+ Coverage 89.69% 89.76% +0.06%
==========================================
Files 28 28
Lines 3183 3184 +1
Branches 579 581 +2
==========================================
+ Hits 2855 2858 +3
+ Misses 172 171 -1
+ Partials 156 155 -1 ☔ View full report in Codecov by Sentry. |
ivojawer
requested review from
fdodino and
PalumboN
and removed request for
fdodino
6 tasks
fdodino
approved these changes
Dec 30, 2024
| return failureResult(`Unknown reference ${unlinkedNode.name}`) | ||
| } else return failureResult(`Unknown reference at ${unlinkedNode.sourceInfo}`) | ||
| } | ||
|
|
||
| const result = interpreter.exec(sentenceOrImport) | ||
| const result = frame ? | ||
| interpreter.do(function () { return interpreter.evaluation.exec(sentenceOrImport, frame) }) : |
There was a problem hiding this comment.
me llamó la atención ver el function ahí en lugar de la lambda
There was a problem hiding this comment.
No tiene ningun motivo de ser 😅 , en esta situacion creo que no hay diferencia entre usar lambdas o funciones anonimas.
| executionDirector.resume() | ||
| const { error, result } = interprete(new Interpreter(directedInterpreter.evaluation), 'energia', directedInterpreter.evaluation.currentFrame) | ||
| expect(error).to.be.undefined | ||
| expect(result).to.equal('100') |
PalumboN
approved these changes
Jan 2, 2025
This was referenced Jan 10, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Este PR tiene dos cambios principales
interpreteahora acepta un frame que actua como el contexto para interpretar la linea (esto es importante para el debugger). Si no defaultea al repl, como hacia antes.